Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935120Ab3DINJY (ORCPT ); Tue, 9 Apr 2013 09:09:24 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:47003 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933121Ab3DINJV (ORCPT ); Tue, 9 Apr 2013 09:09:21 -0400 Date: Tue, 9 Apr 2013 09:09:20 -0400 (EDT) From: Bob Peterson To: Lukas Czerner Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com Message-ID: <686810645.4576872.1365512960001.JavaMail.root@redhat.com> In-Reply-To: <1365498867-27782-9-git-send-email-lczerner@redhat.com> References: <1365498867-27782-1-git-send-email-lczerner@redhat.com> <1365498867-27782-9-git-send-email-lczerner@redhat.com> Subject: Re: [PATCH v3 08/18] gfs2: use ->invalidatepage() length argument MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.12] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF20 (Linux)/8.0.3_GA_5664) Thread-Topic: gfs2: use ->invalidatepage() length argument Thread-Index: Zd1lfSbI9t95W0XN/+A5wmyGKBeONA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1769 Lines: 63 Hi, ----- Original Message ----- | ->invalidatepage() aop now accepts range to invalidate so we can make | use of it in gfs2_invalidatepage(). | | Signed-off-by: Lukas Czerner | Cc: cluster-devel@redhat.com | --- | fs/gfs2/aops.c | 9 +++++++-- | 1 files changed, 7 insertions(+), 2 deletions(-) | | diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c | index 37093ba..ea920bf 100644 | --- a/fs/gfs2/aops.c | +++ b/fs/gfs2/aops.c | @@ -947,24 +947,29 @@ static void gfs2_invalidatepage(struct page *page, | unsigned int offset, | unsigned int length) | { | struct gfs2_sbd *sdp = GFS2_SB(page->mapping->host); | + unsigned int stop = offset + length; | + int partial_page = (offset || length < PAGE_CACHE_SIZE); | struct buffer_head *bh, *head; | unsigned long pos = 0; | | BUG_ON(!PageLocked(page)); | - if (offset == 0) | + if (!partial_page) | ClearPageChecked(page); | if (!page_has_buffers(page)) | goto out; | | bh = head = page_buffers(page); | do { | + if (pos + bh->b_size > stop) | + return; | + I always regret it when I review something this early in the morning, or post before the caffeine has taken full effect. But... Shouldn't the statement above be (1) ">= stop" and (2) goto out;? | if (offset <= pos) | gfs2_discard(sdp, bh); | pos += bh->b_size; | bh = bh->b_this_page; | } while (bh != head); | out: | - if (offset == 0) | + if (!partial_page) | try_to_release_page(page, 0); | } Regards, Bob Peterson Red Hat File Systems -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/