Message-ID: <1365520325.25498.64.camel@gandalf.local.home>
Subject: Re: [PATCH 3/4] uprobes/tracing: Kill the pointless
 local_save_flags/preempt_count calls
From: Steven Rostedt <rostedt@goodmis.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Anton Arapov <anton@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Date: Tue, 09 Apr 2013 11:12:05 -0400
In-Reply-To: <20130409145851.GB22913@redhat.com>
References: <20130329181545.GA20697@redhat.com>
	 <1365436722.25498.14.camel@gandalf.local.home>
	 <20130409145851.GB22913@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 821
Lines: 22

On Tue, 2013-04-09 at 16:58 +0200, Oleg Nesterov wrote:

> Hmm, just to remind which arguments trace_current_buffer_*() has?
> 
> Personally I disagree. And, for example, ftrace_syscall_enter/exit just
> use 0,0 for the same reason.
> 
> So please tell me if you really want the dummy variables/arguments, in
> this case I'll change this code even if I do not like it.

I'm not attached to it, so if you really don't like it, then sure, go
ahead and scrap it. I was just fueled by the hatred of "1" and "2" in
your other patch that it carried over to this one ;-)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/