Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935758Ab3DIRUa (ORCPT ); Tue, 9 Apr 2013 13:20:30 -0400 Received: from terminus.zytor.com ([198.137.202.10]:50193 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935624Ab3DIRUZ (ORCPT ); Tue, 9 Apr 2013 13:20:25 -0400 Message-ID: <51644DC1.2030602@zytor.com> Date: Tue, 09 Apr 2013 10:20:01 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Vivek Goyal CC: Yinghai Lu , Thomas Gleixner , Ingo Molnar , WANG Chao , "Eric W. Biederman" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] x86, kdump: Change crashkernel_high/low= to crashkernel=;high/low References: <1365113821-22749-1-git-send-email-yinghai@kernel.org> <1365113821-22749-5-git-send-email-yinghai@kernel.org> <20130409134544.GA6320@redhat.com> <20130409164720.GJ6320@redhat.com> <51644698.2010203@zytor.com> <20130409171203.GA12209@redhat.com> In-Reply-To: <20130409171203.GA12209@redhat.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 41 On 04/09/2013 10:12 AM, Vivek Goyal wrote: > On Tue, Apr 09, 2013 at 09:49:28AM -0700, H. Peter Anvin wrote: >> On 04/09/2013 09:47 AM, Vivek Goyal wrote: >>> On Tue, Apr 09, 2013 at 08:00:57AM -0700, H. Peter Anvin wrote: >>>> Please, no semicolons. We already have established syntax for suboptions (option=suboption,suboption,...) and suboptions with parameters (option=suboption:value,...) >>> >>> Ok, to understand it better, so crashkernel= will look as follows? >>> >>> crashkernel=suboption[,suboption[,....]][@offset] >>> >>> A suboption can be. >>> >>> - A memory value (128[KMG]) >>> - A range with value (range:size) >>> - Or a property influencing memory allocation behavior (e.g high or low) >>> >>> If yes, sounds good. >>> >> >> Sorry, I don't quite grok @offset and range:size here. > > And @offset means that reserve memory at a particular offset, if > available. > OK, the @offset should probably be treated as a suboption, with an implicit/optional comma. Otherwise, makes sense to me. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/