Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935210Ab3DIR6B (ORCPT ); Tue, 9 Apr 2013 13:58:01 -0400 Received: from mail-qa0-f42.google.com ([209.85.216.42]:32785 "EHLO mail-qa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140Ab3DIR57 (ORCPT ); Tue, 9 Apr 2013 13:57:59 -0400 Date: Tue, 9 Apr 2013 10:57:53 -0700 From: Tejun Heo To: Mikulas Patocka Cc: Jens Axboe , Vivek Goyal , Mike Snitzer , Milan Broz , dm-devel@redhat.com, Andi Kleen , dm-crypt@saout.de, linux-kernel@vger.kernel.org, Christoph Hellwig , Christian Schmidt Subject: Re: dm-crypt parallelization patches Message-ID: <20130409175753.GA6186@mtj.dyndns.org> References: <20130326122713.GC27610@agk-dp.fab.redhat.com> <5151FF82.6090405@gmail.com> <20130326202837.GA5599@redhat.com> <20130328185327.GF14088@htj.dyndns.org> <20130328193343.GA15969@redhat.com> <20130328194443.GG14088@htj.dyndns.org> <20130328203808.GC15969@redhat.com> <20130328204522.GA25501@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 24 On Tue, Apr 09, 2013 at 01:51:43PM -0400, Mikulas Patocka wrote: > The patch dm-crypt-sort-requests.patch sorts write requests submitted by a > single thread. The requests are sorted according to the sector number, > rb-tree is used for efficient sorting. Hmmm? Why not just keep the issuing order along with plugging boundaries? > So it seems that CFQ has some deficiency that it cannot merge adjacent > requests done by different processes. As I wrote before, please use bio_associate_current(). Currently, dm-crypt is completely messing up all the context information that cfq depends on to schedule IOs. Of course, it doesn't perform well. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/