Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933797Ab3DISFz (ORCPT ); Tue, 9 Apr 2013 14:05:55 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:24638 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753721Ab3DISFx (ORCPT ); Tue, 9 Apr 2013 14:05:53 -0400 Date: Tue, 9 Apr 2013 11:03:52 -0700 From: "Darrick J. Wong" To: Jan Kara , Andrew Morton Cc: Mel Gorman , Shuge , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, Kevin , "Theodore Ts'o" , Jens Axboe , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] mm: Make snapshotting pages for stable writes a per-bio operation Message-ID: <20130409180352.GA8907@blackbox.djwong.org> References: <20130313194429.GE5313@blackbox.djwong.org> <20130313210216.GA7754@quack.suse.cz> <20130314224243.GI5313@blackbox.djwong.org> <20130315100105.GA4889@quack.suse.cz> <20130315232816.GN5313@blackbox.djwong.org> <20130318174134.GB7852@quack.suse.cz> <20130318230259.GP5313@blackbox.djwong.org> <20130402170143.GA8910@blackbox.djwong.org> <20130403142019.GC5811@suse.de> <20130403144244.GC14667@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130403144244.GC14667@quack.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2054 Lines: 47 On Wed, Apr 03, 2013 at 04:42:44PM +0200, Jan Kara wrote: > On Wed 03-04-13 15:20:19, Mel Gorman wrote: > > On Tue, Apr 02, 2013 at 10:01:43AM -0700, Darrick J. Wong wrote: > > > Hi, > > > > > > A couple of weeks have gone by without further comments about this patch. > > > > > > Are you interested in the minor cleanups and added comments, or is the v2 patch > > > in -next good enough? > > > > > > Apparently Mel Gorman's interested in this patchset too. Mel: Most of stable > > > pages part 2 are already in upstream for 3.9... except this piece. Are you > > > interested in having this piece in 3.9 also? Or is 3.10 good enough for > > > everyone? > > > > > > > My understanding is that it only affects ARM and DEBUG_VM so there is a > > relatively small chance of this generating spurious bug reports. However, > > 3.9 is still far enough away that I see no good reason to delay this patch > > until 3.10 either. > No, actually with direct IO, anything that needs stable pages is going to > blow up quickly because pages attached to bio needn't be from page cache. So > I think it should better make it into 3.9. Hmm. The previous version of this patch has been hanging around in -next for a few weeks without problems (afaik). With just a raw 3.9-rc[56] I haven't been able to produce a failed checksum or kernel crash when running with O_DIRECT, either with the write-after-checksum reproducer or even a simple dd oflag=direct. But maybe I've gotten lucky on x86? So... Andrew: Would you like to pick up the patch with more descriptive comments? And, is it too late to push it for 3.9? Jan seems to think we might have a bug (though I haven't encountered it). I'll resend the patch just in case it got eaten. --D > > Honza > -- > Jan Kara > SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/