Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936229Ab3DIUdu (ORCPT ); Tue, 9 Apr 2013 16:33:50 -0400 Received: from terminus.zytor.com ([198.137.202.10]:51841 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933489Ab3DIUdu (ORCPT ); Tue, 9 Apr 2013 16:33:50 -0400 Message-ID: <51647B21.6070402@zytor.com> Date: Tue, 09 Apr 2013 13:33:37 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Vivek Goyal CC: Yinghai Lu , Thomas Gleixner , Ingo Molnar , WANG Chao , "Eric W. Biederman" , Linux Kernel Mailing List Subject: Re: [PATCH v3 3/4] x86, kdump: Change crashkernel_high/low= to crashkernel=;high/low References: <1365113821-22749-1-git-send-email-yinghai@kernel.org> <1365113821-22749-5-git-send-email-yinghai@kernel.org> <20130409134544.GA6320@redhat.com> <5164790E.7@zytor.com> <20130409202948.GQ6320@redhat.com> In-Reply-To: <20130409202948.GQ6320@redhat.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 36 On 04/09/2013 01:29 PM, Vivek Goyal wrote: > On Tue, Apr 09, 2013 at 01:24:46PM -0700, H. Peter Anvin wrote: >> On 04/09/2013 01:05 PM, Yinghai Lu wrote: >>>> >>>> So crashkernel=X@Y;high is a valid syntax? Looks like we will reserve >>>> X amount of RAM at base Y and ignore "high" or "low". >>> >>> yes, we should reject them. >>> >> >> What if there isn't X amount of RAM available at base Y? > > We don't reserve anything. > > In this context crashkernel=X@Y,high is invalid syntax and should probably > be ignored by parser. The very fact user specified the offset, high or > low option does not carry any meaning. > > crashkernel=X,high is valid though. > Yes, if the offset being invalid is an error, that is the right behavior, I would think. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/