Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935849Ab3DJC0E (ORCPT ); Tue, 9 Apr 2013 22:26:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48526 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765455Ab3DJC0B (ORCPT ); Tue, 9 Apr 2013 22:26:01 -0400 Date: Tue, 09 Apr 2013 22:24:58 -0400 From: Naoya Horiguchi To: KOSAKI Motohiro Cc: "linux-mm@kvack.org" , Andrew Morton , Mel Gorman , Hugh Dickins , Andi Kleen , Hillf Danton , Michal Hocko , LKML Message-ID: <1365560698-qyvvld1y-mutt-n-horiguchi@ah.jp.nec.com> In-Reply-To: References: <1363983835-20184-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1363983835-20184-10-git-send-email-n-horiguchi@ah.jp.nec.com> <515F68BB.3010601@gmail.com> <1365538036-pu7x5mck-mutt-n-horiguchi@ah.jp.nec.com> <1365547416-z92y6qa9-mutt-n-horiguchi@ah.jp.nec.com> Subject: Re: [PATCH 09/10] memory-hotplug: enable memory hotplug to handle hugepage Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Mutt-References: X-Mutt-Fcc: ~/Maildir/sent/ User-Agent: Mutt 1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 29 On Tue, Apr 09, 2013 at 09:56:58PM -0400, KOSAKI Motohiro wrote: > On Tue, Apr 9, 2013 at 6:43 PM, Naoya Horiguchi ... > > MIGRATE_ISOLTE is changed only within the range [start_pfn, end_pfn) > > given as the argument of __offline_pages (see also start_isolate_page_range), > > so it's set only for pages within the single memblock to be offlined. > > When partial memory hot remove, that's correct behavior. different > node is not required. > > > BTW, in previous discussion I already agreed with checking migrate type > > in hugepage allocation code (maybe it will be in dequeue_huge_page_vma(),) > > so what you concern should be solved in the next post. > > Umm.. Maybe I missed such discussion. Do you have a pointer? Please see the bottom of the following: http://thread.gmane.org/gmane.linux.kernel.mm/96665/focus=96920 It's not exactly the same, but we need to prevent the allocation from the memblock under hotremoving not only to be efficient, but also to avoid the race. Thanks, Naoya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/