Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751456Ab3DJEOG (ORCPT ); Wed, 10 Apr 2013 00:14:06 -0400 Received: from intranet.asianux.com ([58.214.24.6]:56454 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969Ab3DJEOE (ORCPT ); Wed, 10 Apr 2013 00:14:04 -0400 X-Spam-Score: -100.7 Message-ID: <5164E6EC.1010803@asianux.com> Date: Wed, 10 Apr 2013 12:13:32 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Rusty Russell CC: "linux-kernel@vger.kernel.org" Subject: [PATCH v3] kernel: module: using strlcpy and strcpy instead of strncpy References: <51615AB0.9060502@asianux.com> <87r4ila8sb.fsf@rustcorp.com.au> <516298E0.9000905@asianux.com> <5163814A.2030006@asianux.com> <877gkb89hv.fsf@rustcorp.com.au> In-Reply-To: <877gkb89hv.fsf@rustcorp.com.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 41 namebuf is NUL terminated string. better always let it ended by '\0'. the module_name() is always the name field of struct module (which is a fixed array), or a literal "kernel", so strcpy is better. Signed-off-by: Chen Gang --- kernel/module.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 3c2c72d..09aeefd 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1283,7 +1283,7 @@ static const struct kernel_symbol *resolve_symbol(struct module *mod, getname: /* We must make copy under the lock if we failed to get ref. */ - strncpy(ownername, module_name(owner), MODULE_NAME_LEN); + strcpy(ownername, module_name(owner)); unlock: mutex_unlock(&module_mutex); return sym; @@ -3464,7 +3464,7 @@ const char *module_address_lookup(unsigned long addr, } /* Make a copy in here where it's safe */ if (ret) { - strncpy(namebuf, ret, KSYM_NAME_LEN - 1); + strlcpy(namebuf, ret, KSYM_NAME_LEN); ret = namebuf; } preempt_enable(); -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/