Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965013Ab3DJKfb (ORCPT ); Wed, 10 Apr 2013 06:35:31 -0400 Received: from ozlabs.org ([203.10.76.45]:47681 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937211Ab3DJKf0 convert rfc822-to-8bit (ORCPT ); Wed, 10 Apr 2013 06:35:26 -0400 From: Rusty Russell To: David Cohen , dhowells@redhat.com Cc: linux-kernel@vger.kernel.org, mark.gross@intel.com, David Cohen Subject: Re: [PATCH v2] MODSIGN: do not send garbage to stderr when enabling modules signature In-Reply-To: <1365543543-17522-1-git-send-email-david.a.cohen@intel.com> References: <1365543543-17522-1-git-send-email-david.a.cohen@intel.com> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Wed, 10 Apr 2013 20:02:10 +0930 Message-ID: <87k3oa65hx.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2680 Lines: 64 David Cohen writes: > openssl may send garbage to stderr when generating X.509 key pair for > modules signature regardless there was an error or not. It makes more > difficult to create scripts based on kernel error/warning messages. > > When compiling kernel with -jN (N > 1), all warning/error messages > printed while openssl is generating key pair may get mixed dots and > other symbols openssl sends to stderr. This patch makes sure openssl > logs go to default stdout. Ah! Not garbage, but it writes progress dots and status messages to stderr? I trimmed your commit message as shown below. Thanks! Rusty. From: David Cohen Subject: MODSIGN: do not send garbage to stderr when enabling modules signature When compiling kernel with -jN (N > 1), all warning/error messages printed while openssl is generating key pair may get mixed dots and other symbols openssl sends to stderr. This patch makes sure openssl logs go to default stdout. Example of the garbage on stderr: crypto/anubis.c:581: warning: ‘inter’ is used uninitialized in this function Generating a 4096 bit RSA private key ......... drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_ggtt_insert_entries’: drivers/gpu/drm/i915/i915_gem_gtt.c:440: warning: ‘addr’ may be used uninitialized in this function .net/mac80211/tx.c: In function ‘ieee80211_subif_start_xmit’: net/mac80211/tx.c:1780: warning: ‘chanctx_conf’ may be used uninitialized in this function ..drivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’: .....drivers/isdn/hardware/mISDN/hfcpci.c:2298: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result Signed-off-by: David Cohen Reviewed-by: mark gross Signed-off-by: Rusty Russell --- kernel/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/Makefile b/kernel/Makefile index bbde5f1..5a51e6c 100644 --- a/kernel/Makefile +++ b/kernel/Makefile @@ -175,7 +175,7 @@ signing_key.priv signing_key.x509: x509.genkey openssl req -new -nodes -utf8 -$(CONFIG_MODULE_SIG_HASH) -days 36500 \ -batch -x509 -config x509.genkey \ -outform DER -out signing_key.x509 \ - -keyout signing_key.priv + -keyout signing_key.priv 2>&1 @echo "###" @echo "### Key pair generated." @echo "###" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/