Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937232Ab3DJKhi (ORCPT ); Wed, 10 Apr 2013 06:37:38 -0400 Received: from intranet.asianux.com ([58.214.24.6]:34846 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935405Ab3DJKhd (ORCPT ); Wed, 10 Apr 2013 06:37:33 -0400 X-Spam-Score: -100.8 Message-ID: <516540CB.7090301@asianux.com> Date: Wed, 10 Apr 2013 18:36:59 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Al Viro , eparis@redhat.com CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kernel: auditfilter: looping issue, memory leak if has 2 or more AUDIT_FILTERKEYs References: <51653645.90401@asianux.com> <51653C7A.6030405@asianux.com> <51653EC2.5030107@asianux.com> In-Reply-To: <51653EC2.5030107@asianux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2307 Lines: 92 also for function audit_list_rules: when call audit_make_reply fails (will return NULL). we also need process data->buf, not only data itself. please help check, thanks. :-) gchen. On 2013年04月10日 18:28, Chen Gang wrote: > > also for function audit_list: > when call audit_make_reply fails (will return NULL). > we need free all its related variables instead of only kfree rull. > (such as call autit_free_rule) > > please help check, thanks. > > :-) > > gchen. > > On 2013年04月10日 18:18, Chen Gang wrote: >> >> >> in another function: audit_data_to_entry: >> >> a. has the same issue for case AUDIT_WATCH. >> >> b. has an new issue for AUDIT_DIR: >> after AUDIT_DIR succeed, it will set rule->tree. >> next, the other case fail, then will call audit_free_rule. >> but audit_free_rule will not free rule->tree. >> >> >> I find them only by reading code, not test them. >> and I also do not know about the related features. >> so please help check my 2 opinions whether are correct. >> >> >> welcome any suggestion or completions. >> >> thanks. >> >> :-) >> >> >> gchen. >> >> >> On 2013年04月10日 17:52, Chen Gang wrote: >>> >>> in the 'fcount' looping, >>> if 'new->fields[*].type" has 2 or more AUDIT_FILTERKEYs >>> need judge new->filterkey whether has value, or memory leak. >>> >>> Signed-off-by: Chen Gang >>> --- >>> kernel/auditfilter.c | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c >>> index f9fc54b..936ac79 100644 >>> --- a/kernel/auditfilter.c >>> +++ b/kernel/auditfilter.c >>> @@ -859,6 +859,8 @@ struct audit_entry *audit_dupe_rule(struct audit_krule *old) >>> &old->fields[i]); >>> break; >>> case AUDIT_FILTERKEY: >>> + if (new->filterkey) >>> + break; >>> fk = kstrdup(old->filterkey, GFP_KERNEL); >>> if (unlikely(!fk)) >>> err = -ENOMEM; >>> >> >> > > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/