Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965232Ab3DJLwe (ORCPT ); Wed, 10 Apr 2013 07:52:34 -0400 Received: from mail-qa0-f44.google.com ([209.85.216.44]:44166 "EHLO mail-qa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965218Ab3DJLw3 (ORCPT ); Wed, 10 Apr 2013 07:52:29 -0400 MIME-Version: 1.0 In-Reply-To: <1365594552.30071.63.camel@laptop> References: <1365521034-4496-1-git-send-email-jacob.shin@amd.com> <1365586878.30071.33.camel@laptop> <1365594552.30071.63.camel@laptop> Date: Wed, 10 Apr 2013 13:52:28 +0200 Message-ID: Subject: Re: [PATCH RESEND 0/3] perf, amd: Support for Family 16h L2I Performance Counters From: Stephane Eranian To: Peter Zijlstra Cc: Jacob Shin , Ingo Molnar , Arnaldo Carvalho de Melo , "H. Peter Anvin" , Thomas Gleixner , x86 , Jiri Olsa , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 35 On Wed, Apr 10, 2013 at 1:49 PM, Peter Zijlstra wrote: > On Wed, 2013-04-10 at 13:38 +0200, Stephane Eranian wrote: >> On Wed, Apr 10, 2013 at 11:41 AM, Peter Zijlstra wrote: >> > >> > On Tue, 2013-04-09 at 10:23 -0500, Jacob Shin wrote: >> > > Upcoming AMD Family 16h Processors provide 4 new performance counters >> > > to count L2 related events. Similar to northbridge counters, these new >> > > counters are shared across multiple CPUs that share the same L2 cache. >> > > This patchset adds support for these new counters and enforces sharing >> > > by leveraging the existing sharing logic used for the northbridge >> > > counters. >> > >> > If they're separate counters -- not shared with the regular cpu >> > counters like the 10h NB counters are, then they should have their own >> > PMU driver. >> > >> > Similar to the 15h NB counters; which are a separate set of counters >> > and no longer overlay the normal counters. >> > >> Well, that's how this was suggested but that's not how it's >> implemented currently >> and committed if I recall. > > Hmm.. the 15h old interface bits got merged? I thought I kept telling > that should be done like the intel uncore stuff since the hardware > interface wasn't retarded anymore. > I remember. I agreed with you on this. I don't recall the details as to why Robert did not like that but I think it had to do with code duplication from the perf_event_amd.c. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/