Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935624Ab3DJN3P (ORCPT ); Wed, 10 Apr 2013 09:29:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52643 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182Ab3DJN3N (ORCPT ); Wed, 10 Apr 2013 09:29:13 -0400 Date: Wed, 10 Apr 2013 14:29:07 +0100 From: Mel Gorman To: Kamezawa Hiroyuki Cc: Andrew Morton , Jiri Slaby , Valdis Kletnieks , Rik van Riel , Zlatko Calusic , Johannes Weiner , dormando , Satoru Moriya , Michal Hocko , Linux-MM , LKML Subject: Re: [PATCH 03/10] mm: vmscan: Flatten kswapd priority loop Message-ID: <20130410132907.GA3710@suse.de> References: <1365505625-9460-1-git-send-email-mgorman@suse.de> <1365505625-9460-4-git-send-email-mgorman@suse.de> <51651913.4040007@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <51651913.4040007@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 31 On Wed, Apr 10, 2013 at 04:47:31PM +0900, Kamezawa Hiroyuki wrote: > > @@ -2811,8 +2814,16 @@ loop_again: > > > > if ((buffer_heads_over_limit && is_highmem_idx(i)) || > > !zone_balanced(zone, testorder, > > - balance_gap, end_zone)) > > - kswapd_shrink_zone(zone, &sc, lru_pages); > > + balance_gap, end_zone)) { > > + /* > > + * There should be no need to raise the > > + * scanning priority if enough pages are > > + * already being scanned that high > > + * watermark would be met at 100% efficiency. > > + */ > > + if (kswapd_shrink_zone(zone, &sc, lru_pages)) > > + raise_priority = false; > > priority will be raised up enough to scan the amount of "high" watermark > and will not get larger than that if some pages are reclaimed ? > Yes. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/