Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936983Ab3DJRAf (ORCPT ); Wed, 10 Apr 2013 13:00:35 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:54467 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752153Ab3DJRAc (ORCPT ); Wed, 10 Apr 2013 13:00:32 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19/Ge4TmVU8E1eHEnKjX2gX Date: Wed, 10 Apr 2013 10:00:26 -0700 From: Tony Lindgren To: Pali =?utf-8?B?Um9ow6Fy?= Cc: linux-kernel@vger.kernel.org, Samuel Ortiz , Anton Vorontsov , Keerthy , Kyle Manna , linux-omap@vger.kernel.org Subject: Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion Message-ID: <20130410170026.GZ10155@atomide.com> References: <1360969010-8571-1-git-send-email-pali.rohar@gmail.com> <201304041132.21158@pali> <20130408181524.GU10155@atomide.com> <201304101612.51620@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201304101612.51620@pali> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2314 Lines: 58 * Pali Rohár [130410 07:17]: > On Monday 08 April 2013 20:15:24 Tony Lindgren wrote: > > * Pali Rohár [130404 02:37]: > > > On Sunday 24 March 2013 15:03:29 Pali Rohár wrote: > > > > On Saturday 02 March 2013 23:23:05 Pali Rohár wrote: > > > > > On Friday 15 February 2013 23:56:49 Pali Rohár wrote: > > > > > > Driver twl4030-madc has hardcoded channel types (10 - > > > > > > battery current, 1 - battery temperature) and also > > > > > > conversation data in variable twl4030_divider_ratios. > > > > > > These hardcoded channels are incorrect for Nokia RX-51 > > > > > > board (where is channel 0 - battery temperature). > > > > > > > > > > > > For Nokia RX-51 there is rx51_battery power_supply > > > > > > driver which reporting battery information via > > > > > > twl4030_madc_conversion. But this driver needs raw > > > > > > values (not converted via some hardcoded functions). > > > > > > So this patch adding new parameter "raw" to struct > > > > > > twl4030_madc_request which tell twl4030-madc driver to > > > > > > not convert values, but rather return raw. > > > > > > > > > > > > Signed-off-by: Pali Rohár > > > > > > --- > > > > > > > > > > > > drivers/mfd/twl4030-madc.c | 14 > > > > > > ++++++++++---- include/linux/i2c/twl4030-madc.h | > > > > > > 2 ++ > > > > > > 2 files changed, 12 insertions(+), 4 deletions(-) > > > > > > > > > > Hello, can somebody review this twl4030-madc patch? > > > > > > > > Bump. > > > > > > > > Can some of mfd maintainers look at this patch and include > > > > it to mfd tree? It is needed for rx51_battery power > > > > supply driver. > > > > > > CCing Tony, can you look at this patch? > > > > Sorry for the delay in replying, I've been going through my > > inbox for the merge window and noticed this. > > > > I suggest resend with Peter Ujfalusi cc:d as he is the > > de-facto twl/tps maintainer and expert by now. > > > > Regards, > > > > Tony > > Ok, both patches are now in mfd-next tree. Great thanks! Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/