Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937087Ab3DJXuy (ORCPT ); Wed, 10 Apr 2013 19:50:54 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:49788 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761186Ab3DJXux (ORCPT ); Wed, 10 Apr 2013 19:50:53 -0400 Date: Wed, 10 Apr 2013 16:50:51 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Rasmus Villemoes cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: madvise: complete input validation before taking lock In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 17 On Wed, 10 Apr 2013, Rasmus Villemoes wrote: > In madvise(), there doesn't seem to be any reason for taking the > ¤t->mm->mmap_sem before start and len_in have been > validated. Incidentally, this removes the need for the out: label. > > > Signed-off-by: Rasmus Villemoes Acked-by: David Rientjes Would be nice to do s/out_plug/out/ now if you have a chance. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/