Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937095Ab3DJX4z (ORCPT ); Wed, 10 Apr 2013 19:56:55 -0400 Received: from mail-vb0-f54.google.com ([209.85.212.54]:43470 "EHLO mail-vb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934808Ab3DJX4y (ORCPT ); Wed, 10 Apr 2013 19:56:54 -0400 Message-ID: <5165FC42.6060304@gmail.com> Date: Wed, 10 Apr 2013 19:56:50 -0400 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Rasmus Villemoes CC: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kosaki.motohiro@gmail.com Subject: Re: [PATCH] mm: madvise: complete input validation before taking lock References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 625 Lines: 18 (4/10/13 7:45 PM), Rasmus Villemoes wrote: > In madvise(), there doesn't seem to be any reason for taking the > ¤t->mm->mmap_sem before start and len_in have been > validated. Incidentally, this removes the need for the out: label. > > > Signed-off-by: Rasmus Villemoes Looks good. Acked-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/