Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754473Ab3DKHIp (ORCPT ); Thu, 11 Apr 2013 03:08:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33285 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514Ab3DKHIo (ORCPT ); Thu, 11 Apr 2013 03:08:44 -0400 Date: Thu, 11 Apr 2013 09:08:40 +0200 From: Michal Hocko To: David Rientjes Cc: Naoya Horiguchi , Andrew Morton , Mel Gorman , Hugh Dickins , Rik van Riel , KOSAKI Motohiro , Konstantin Khlebnikov , HATAYAMA Daisuke , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND][PATCH v5 2/3] fix hugetlb memory check in vma_dump_size() Message-ID: <20130411070832.GA1488@dhcp22.suse.cz> References: <1365610669-16625-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1365610669-16625-3-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 34 On Wed 10-04-13 14:49:07, David Rientjes wrote: > On Wed, 10 Apr 2013, Naoya Horiguchi wrote: > > > Documentation/filesystems/proc.txt says about coredump_filter bitmask, > > > > Note bit 0-4 doesn't effect any hugetlb memory. hugetlb memory are only > > effected by bit 5-6. > > > > However current code can go into the subsequent flag checks of bit 0-4 > > for vma(VM_HUGETLB). So this patch inserts 'return' and makes it work > > as written in the document. > > > > Signed-off-by: Naoya Horiguchi > > Reviewed-by: Rik van Riel > > Acked-by: Michal Hocko > > Reviewed-by: HATAYAMA Daisuke > > Acked-by: KOSAKI Motohiro > > Cc: stable@vger.kernel.org > > Acked-by: David Rientjes > > Stable for 2.6.34+. I think it is only 3.7+ as well because VM_RESERVED stopped use before (314e51b9). -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/