Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395Ab3DKJxd (ORCPT ); Thu, 11 Apr 2013 05:53:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39880 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043Ab3DKJxc (ORCPT ); Thu, 11 Apr 2013 05:53:32 -0400 Date: Thu, 11 Apr 2013 10:53:25 +0100 From: Mel Gorman To: Dave Chinner Cc: Joonsoo Kim , Linux-MM , Jiri Slaby , Valdis Kletnieks , Rik van Riel , Zlatko Calusic , Johannes Weiner , dormando , Satoru Moriya , Michal Hocko , LKML Subject: Re: [PATCH 08/10] mm: vmscan: Have kswapd shrink slab only once per priority Message-ID: <20130411095325.GI3710@suse.de> References: <1363525456-10448-1-git-send-email-mgorman@suse.de> <1363525456-10448-9-git-send-email-mgorman@suse.de> <20130409065325.GA4411@lge.com> <20130409111358.GB2002@suse.de> <20130410010734.GR17758@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20130410010734.GR17758@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 34 On Wed, Apr 10, 2013 at 11:07:34AM +1000, Dave Chinner wrote: > On Tue, Apr 09, 2013 at 12:13:59PM +0100, Mel Gorman wrote: > > On Tue, Apr 09, 2013 at 03:53:25PM +0900, Joonsoo Kim wrote: > > > > > I think that outside of zone loop is better place to run shrink_slab(), > > > because shrink_slab() is not directly related to a specific zone. > > > > > > > This is true and has been the case for a long time. The slab shrinkers > > are not zone aware and it is complicated by the fact that slab usage can > > indirectly pin memory on other zones. > ...... > > > And this is a question not related to this patch. > > > Why nr_slab is used here to decide zone->all_unreclaimable? > > > > Slab is not directly associated with a slab but as reclaiming slab can > > free memory from unpredictable zones we do not consider a zone to be > > fully unreclaimable until we cannot shrink slab any more. > > This is something the numa aware shrinkers will greatly help with - > instead of being a global shrink it becomes a > node-the-zone-belongs-to shrink, and so.... > Yes, 100% agreed. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/