Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756972Ab3DKNO3 (ORCPT ); Thu, 11 Apr 2013 09:14:29 -0400 Received: from 1wt.eu ([62.212.114.60]:32786 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796Ab3DKNO1 (ORCPT ); Thu, 11 Apr 2013 09:14:27 -0400 Date: Thu, 11 Apr 2013 15:13:33 +0200 From: Willy Tarreau To: Sebastian Hesselbarth Cc: Andrew Lunn , Jason Cooper , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, "David S. Miller" , Soeren Moch , Paul Mackerras , linux-arm-kernel@lists.infradead.org, Dale Farnsworth , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Florian Fainelli , Lennert Buytenhek Subject: Re: [PATCH] net: mv643xx_eth: Add GRO support Message-ID: <20130411131333.GD1910@1wt.eu> References: <1365684023-9967-1-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365684023-9967-1-git-send-email-sebastian.hesselbarth@gmail.com> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2414 Lines: 61 Hi, On Thu, Apr 11, 2013 at 02:40:23PM +0200, Sebastian Hesselbarth wrote: > This patch adds GRO support to mv643xx_eth by making it invoke > napi_gro_receive instead of netif_receive_skb. > > Signed-off-by: Soeren Moch > Signed-off-by: Sebastian Hesselbarth > --- > Cc: "David S. Miller" > Cc: Lennert Buytenhek > Cc: Andrew Lunn > Cc: Jason Cooper > Cc: Florian Fainelli > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Dale Farnsworth > Cc: netdev@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c > index 305038f..c850d04 100644 > --- a/drivers/net/ethernet/marvell/mv643xx_eth.c > +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c > @@ -604,7 +604,7 @@ static int rxq_process(struct rx_queue *rxq, int budget) > lro_receive_skb(&rxq->lro_mgr, skb, (void *)cmd_sts); > lro_flush_needed = 1; > } else > - netif_receive_skb(skb); > + napi_gro_receive(&mp->napi, skb); > > continue; I remember having experimented with this on 3.6 a few months ago with this driver and finally switching back to something like this instead which showed better performance on my tests : if (skb->ip_summed == CHECKSUM_UNNECESSARY) napi_gro_receive(napi, skb); else netif_receive_skb(skb); Unfortunately I don't have more details as my commit message was rather short due to this resulting from experimentation. Did you verify that you did not lose any performance in various workloads ? I was playing with bridges at this time, it's possible that I got better performance on bridging with netif_receive_skb() than with napi_gro_receive(). Regards, Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/