Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936453Ab3DKP1I (ORCPT ); Thu, 11 Apr 2013 11:27:08 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:57800 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936277Ab3DKP1F (ORCPT ); Thu, 11 Apr 2013 11:27:05 -0400 MIME-Version: 1.0 In-Reply-To: <20130411150326.GA19978@1wt.eu> References: <1365684023-9967-1-git-send-email-sebastian.hesselbarth@gmail.com> <20130411131333.GD1910@1wt.eu> <20130411150326.GA19978@1wt.eu> Date: Thu, 11 Apr 2013 17:27:03 +0200 Message-ID: Subject: Re: [PATCH] net: mv643xx_eth: Add GRO support From: Sebastian Hesselbarth To: Willy Tarreau Cc: Andrew Lunn , Jason Cooper , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, Florian Fainelli , Soeren Moch , Paul Mackerras , Lennert Buytenhek , Dale Farnsworth , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 25 On Thu, Apr 11, 2013 at 5:03 PM, Willy Tarreau wrote: > On Thu, Apr 11, 2013 at 04:47:49PM +0200, Sebastian Hesselbarth wrote: >> I tried todays net-next on top of 3.9-rc6 without any gro patch, with >> the initial >> patch (Soeren) and your proposed patch (Willy). The results show that >> both patches >> allow a significant increase in throughput compared to >> netif_receive_skb (!gro, !lro) >> alone. Having gro with lro disabled gives some 2% more throughput >> compared to lro only. > > Indeed this is consistent with my memories, since Eric improved the > GRO path, it became faster than LRO on this chip. I don't have a strong opinion on whether Soeren's or your proposal should be submitted. But I insist on having one of them in, as GRO significantly improves the common use case, is enabled by default, and not as constrained as LRO. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/