Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753675Ab3DKPym (ORCPT ); Thu, 11 Apr 2013 11:54:42 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:57404 "EHLO mail-pb0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694Ab3DKPyk (ORCPT ); Thu, 11 Apr 2013 11:54:40 -0400 Message-ID: <1365695675.3887.165.camel@edumazet-glaptop> Subject: Re: [PATCH] net: mv643xx_eth: Add GRO support From: Eric Dumazet To: Willy Tarreau Cc: Sebastian Hesselbarth , Andrew Lunn , Jason Cooper , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, Florian Fainelli , Soeren Moch , Paul Mackerras , Lennert Buytenhek , Dale Farnsworth , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org Date: Thu, 11 Apr 2013 08:54:35 -0700 In-Reply-To: <20130411153256.GH1910@1wt.eu> References: <1365684023-9967-1-git-send-email-sebastian.hesselbarth@gmail.com> <20130411131333.GD1910@1wt.eu> <20130411150326.GA19978@1wt.eu> <20130411153256.GH1910@1wt.eu> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 27 On Thu, 2013-04-11 at 17:32 +0200, Willy Tarreau wrote: > On Thu, Apr 11, 2013 at 05:27:03PM +0200, Sebastian Hesselbarth wrote: > > I don't have a strong opinion on whether Soeren's or your proposal should > > be submitted. But I insist on having one of them in, as GRO significantly > > improves the common use case, is enabled by default, and not as > > constrained as LRO. > > I agree, use yours first, but we should keep an eye on this. Since you have > everything to run a test, please try to see if you can get netperf to run > over IPv6, I'm sure the NIC doesn't handle it. Willy, testing the checksum in the NIC driver itself prevents the stack doing GRO even if the NIC could not checksum the packet, as in GRE tunneling for example. So Sebastien patch is better IMHO : Just call the napi gro handler and let core stack handles the details ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/