Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965217Ab3DKR4C (ORCPT ); Thu, 11 Apr 2013 13:56:02 -0400 Received: from webmail.solarflare.com ([12.187.104.25]:50622 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965045Ab3DKR4A (ORCPT ); Thu, 11 Apr 2013 13:56:00 -0400 Message-ID: <1365702955.7355.5.camel@bwh-desktop.uk.solarflarecom.com> Subject: Re: [PATCH] net: mv643xx_eth: Add GRO support From: Ben Hutchings To: Sebastian Hesselbarth CC: Soeren Moch , "David S. Miller" , Lennert Buytenhek , Andrew Lunn , Jason Cooper , Florian Fainelli , Benjamin Herrenschmidt , Paul Mackerras , Dale Farnsworth , , , , Date: Thu, 11 Apr 2013 18:55:55 +0100 In-Reply-To: <1365684023-9967-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1365684023-9967-1-git-send-email-sebastian.hesselbarth@gmail.com> Organization: Solarflare Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.17.20.137] X-TM-AS-Product-Ver: SMEX-10.0.0.1412-7.000.1014-19790.000 X-TM-AS-Result: No--10.544500-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1997 Lines: 52 On Thu, 2013-04-11 at 14:40 +0200, Sebastian Hesselbarth wrote: > This patch adds GRO support to mv643xx_eth by making it invoke > napi_gro_receive instead of netif_receive_skb. The inet_lro support should be removed at the same time; inet_lro is now deprecated and there should be no need to keep both of them. Ben. > Signed-off-by: Soeren Moch > Signed-off-by: Sebastian Hesselbarth > --- > Cc: "David S. Miller" > Cc: Lennert Buytenhek > Cc: Andrew Lunn > Cc: Jason Cooper > Cc: Florian Fainelli > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Dale Farnsworth > Cc: netdev@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c > index 305038f..c850d04 100644 > --- a/drivers/net/ethernet/marvell/mv643xx_eth.c > +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c > @@ -604,7 +604,7 @@ static int rxq_process(struct rx_queue *rxq, int budget) > lro_receive_skb(&rxq->lro_mgr, skb, (void *)cmd_sts); > lro_flush_needed = 1; > } else > - netif_receive_skb(skb); > + napi_gro_receive(&mp->napi, skb); > > continue; > -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/