Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100Ab3DKTOo (ORCPT ); Thu, 11 Apr 2013 15:14:44 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:51136 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501Ab3DKTOm (ORCPT ); Thu, 11 Apr 2013 15:14:42 -0400 MIME-Version: 1.0 In-Reply-To: <1365705391-23181-1-git-send-email-abrestic@chromium.org> References: <1365705391-23181-1-git-send-email-abrestic@chromium.org> Date: Thu, 11 Apr 2013 12:14:40 -0700 X-Google-Sender-Auth: MbmwEUp4NurTIoI_ePbHVom0YEM Message-ID: Subject: Re: [PATCH] backlight: platform_lcd: introduce probe callback From: Doug Anderson To: Andrew Bresticker Cc: linux-fbdev@vger.kernel.org, Richard Purdie , Florian Tobias Schandinat , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 19 Andrew, On Thu, Apr 11, 2013 at 11:36 AM, Andrew Bresticker wrote: > + if (pdata->probe) { > + err = pdata->probe(pdata); > + if (err) { > + dev_err(dev, "platform probe failed: %d\n", err); It would probably be good not to print in the case of -EPROBE_DEFER? Otherwise this looks good to me. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/