Date: Tue, 24 Sep 2002 07:23:06 +0200
From: Frank v Waveren <fvw@var.cx>
To: linux-kernel@vger.kernel.org
Subject: isofs forcing cruft on volset# > 1
Message-ID: <1032843561MGN.fvw@jareth.var.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1347
Lines: 25

Currently the isofs driver forces the 'cruft' option (which does some
nasty stuff like setting maximum filesize to 16mb to salvage malformed
filesystems) on filesystems that have a volume set sequence number
which is not 0 or 1. (linux/fs/isofs/inode.c:1273)

This has been brought up twice here, and gotten no replies. Could
someone please give a reason why we can't accept volume set sequence
numbers, even if we're not exporting them to userspace in any way?

If no-one has a any reasons why not I'll ask hpa to remove the check
or as Stanislav Brabec (utx@penguin.cz) suggested replace it by
testing if the highest byte of the sequence number is set, if this
helps detect some broken images (though I am hesitant to mark any
valid filesystem as cruft just on some heuristic that may be wrong,
even though having more than 16777215 CD's in a set does seem unlikely).

-- 
Frank v Waveren                                      Fingerprint: 0EDB 8787
fvw@[var.cx|stack.nl|dse.nl|chello.nl] ICQ#10074100     09B9 6EF5 6425 B855
Public key: hkp://wwwkeys.pgp.net/fvw@var.cx            7179 3036 E136 B85D
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/