Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935880Ab3DKVQK (ORCPT ); Thu, 11 Apr 2013 17:16:10 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:43027 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935533Ab3DKVQH (ORCPT ); Thu, 11 Apr 2013 17:16:07 -0400 Message-ID: <51672806.5040501@ti.com> Date: Thu, 11 Apr 2013 17:15:50 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Amit Daniel Kachhap CC: , Thomas Abraham , Zhang Rui , , , , Kukjin Kim , , Subject: Re: [9/9] ARM: dts: Add device tree node for exynos5440 TMU controller References: <1364297642-2746-10-git-send-email-amit.daniel@samsung.com> In-Reply-To: <1364297642-2746-10-git-send-email-amit.daniel@samsung.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2335 Lines: 84 Amit, Copying Grant for DT. On 26-03-2013 07:34, Amit Daniel Kachhap wrote: > This patch adds device node for TMU controller. There are 3 > instances of the controllers so 3 nodes are created. > > Signed-off-by: Amit Daniel Kachhap > > --- > arch/arm/boot/dts/exynos5440.dtsi | 43 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 43 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi > index 5f3562a..b74ce9f 100644 > --- a/arch/arm/boot/dts/exynos5440.dtsi > +++ b/arch/arm/boot/dts/exynos5440.dtsi > @@ -16,6 +16,12 @@ > > interrupt-parent = <&gic>; > > + aliases { > + tmuctrl0 = &tmuctrl_0; > + tmuctrl1 = &tmuctrl_1; > + tmuctrl2 = &tmuctrl_2; > + }; > + > gic:interrupt-controller@2E0000 { > compatible = "arm,cortex-a15-gic"; > #interrupt-cells = <3>; > @@ -156,4 +162,41 @@ > reg = <0x130000 0x1000>; > interrupts = <0 17 0>, <0 16 0>; > }; > + > + tmu_ctrl_info: tmu-ctrl-info { > + gain = <5>; > + reference-voltage = <16>; > + noise-cancel-mode = <4>; > + cal-type = <2>; > + cal-mode = <0>; > + efuse-value = <0x5b2c>; > + threshold-falling = <5>; > + }; > + > + tmuctrl_0: tmuctrl@160118 { > + compatible = "samsung,exynos5440-tmu"; > + reg = <0x160118 0x300>; > + interrupts = <0 58 0>; > + clocks = <&clock 8>; > + clock-names = "tmu_apbif"; > + tmu-ctrl-data = <&tmu_ctrl_info>; > + }; > + > + tmuctrl_1: tmuctrl@16011C { > + compatible = "samsung,exynos5440-tmu"; > + reg = <0x16011C 0x300>; > + interrupts = <0 58 0>; > + clocks = <&clock 8>; > + clock-names = "tmu_apbif"; > + tmu-ctrl-data = <&tmu_ctrl_info>; > + }; > + > + tmuctrl_2: tmuctrl@160120 { > + compatible = "samsung,exynos5440-tmu"; > + reg = <0x160120 0x300>; > + interrupts = <0 58 0>; > + clocks = <&clock 8>; > + clock-names = "tmu_apbif"; > + tmu-ctrl-data = <&tmu_ctrl_info>; > + }; Grant, how the above thermal data must be handled in DT? Is it fine to create private phandles like that? > }; > Please consider the comments on patch 8. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/