Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753831Ab3DKVlX (ORCPT ); Thu, 11 Apr 2013 17:41:23 -0400 Received: from mout.gmx.net ([212.227.15.18]:52599 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909Ab3DKVlW (ORCPT ); Thu, 11 Apr 2013 17:41:22 -0400 X-Authenticated: #12255092 X-Provags-ID: V01U2FsdGVkX19B3MgyKvFB8D+2lgxaEH/nyAzOHxttz+x7klmrls p7WseHgQ8XhVWQ From: Peter =?iso-8859-1?q?H=FCwe?= To: tpmdd-devel@lists.sourceforge.net, Matthias Leblanc Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics st33 driver SPI Date: Thu, 11 Apr 2013 23:44:04 +0200 User-Agent: KMail/1.13.7 (Linux/3.8.4; KDE/4.9.5; x86_64; ; ) Cc: Mathias LEBLANC , Kent Yoder , "Jean-Luc BLANC" , "linux-kernel@vger.kernel.org" , Mathias leblanc References: <1365518562-3678-1-git-send-email-mathias.leblanc@st.com> <201304102232.06682.PeterHuewe@gmx.de> <35286B1AE75A7C47BFF0870081A31B4B45A568E70B@SAFEX1MAIL4.st.com> In-Reply-To: <35286B1AE75A7C47BFF0870081A31B4B45A568E70B@SAFEX1MAIL4.st.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201304112344.04576.PeterHuewe@gmx.de> X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 23 Hi Matthias, Am Donnerstag, 11. April 2013, 10:58:59 schrieb Mathias LEBLANC: > Hi Peter, > > Yes, you have right, these error are generated by #ifndef > __STM_ST33_TPM_SPI_H__ Just remove it and the #endif next the structure. Yes, I know that - for the submission to be included this has to be changed by you. > Did you have these warning when you have run checkpatch script? You mean the sparse warnings I sent you? I removed the superflous ifdef to compile it and then let sparse run against it. The driver passes normal checkpatch check, unless you call it with -strict Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/