From: "yongjun_wei@trendmicro.com.cn" <yongjun_wei@trendmicro.com.cn>
To: Eric Paris <eparis@redhat.com>, Wei Yongjun <weiyj.lk@gmail.com>
CC: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] audit: remove duplicated include from audit.c
Thread-Topic: [PATCH -next] audit: remove duplicated include from audit.c
Thread-Index: Ac43Lc94QGubB33dQHGvphSp1r0KFg==
Date: Fri, 12 Apr 2013 03:28:34 +0000
Message-ID: <A360F954C61C69449463B0606663711259EE4EBC@CDCEXMBX01.tw.trendnet.org>
References: <CAPgLHd-M-q-xf+mp3VTAabxXS3bOjZ4g8EWLeE2NdjC2O7qCSA@mail.gmail.com>
 <170253117.11083340.1365614765343.JavaMail.root@redhat.com>
In-Reply-To: <170253117.11083340.1365614765343.JavaMail.root@redhat.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain;
	charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 2316
Lines: 67

Hi Eric,

Sorry reply on top.

>From the source code from linex-next.git tree, line 55~64:

#include <net/sock.h>
#include <net/netlink.h>            *******
#include <linux/skbuff.h>
#ifdef CONFIG_SECURITY
#include <linux/security.h>
#endif
#include <net/netlink.h>            *******
#include <linux/freezer.h>
#include <linux/tty.h>
#include <linux/pid_namespace.h>

net/netlink.h is included twice, and linux/netlink.h is not included by this file.

-----Original Message-----
From: Eric Paris [mailto:eparis@redhat.com] 
Sent: 2013年4月11日 1:26
To: Wei Yongjun
Cc: viro@zeniv.linux.org.uk; Yongjun Wei (RD-CN); linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] audit: remove duplicated include from audit.c

net/netlink.h includes linux/netlink.h but linux/netlink.h does not include net/netlink.h

since the audit code uses the nlmsg_* functions provided in net/netlink.h it seems we need this include.

since the audit code uses netlink_unicast provided in linux/netlink.h it seems we need that include.

I don't see duplication even if by chance one of them would have included the other...

----- Original Message -----
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  kernel/audit.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/audit.c b/kernel/audit.c index 488f85f..9377913 
> 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -58,7 +58,6 @@
>  #ifdef CONFIG_SECURITY
>  #include <linux/security.h>
>  #endif
> -#include <net/netlink.h>
>  #include <linux/freezer.h>
>  #include <linux/tty.h>
>  #include <linux/pid_namespace.h>
> 
> 

<table class="TM_EMAIL_NOTICE"><tr><td><pre>
TREND MICRO EMAIL NOTICE
The information contained in this email and any attachments is confidential 
and may be subject to copyright or other intellectual property protection. 
If you are not the intended recipient, you are not authorized to use or 
disclose this information, and we request that you notify us by reply mail or
telephone and delete the original message from your mail system.
</pre></td></tr></table>????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?