Message-ID: <5167C36A.5000700@asianux.com>
Date: Fri, 12 Apr 2013 16:18:50 +0800
From: Chen Gang <gang.chen@asianux.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Eric Paris <eparis@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: audit_watch: resource management: better reset
 to NULL.
References: <516790ED.6060202@asianux.com> <516792A6.9050904@asianux.com>
In-Reply-To: <516792A6.9050904@asianux.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1096
Lines: 39


  oh, sorry, this patch is incorrect, please skip it.


On 2013年04月12日 12:50, Chen Gang wrote:
> 
>   better to set krule->watch = NULL.
>   maybe it is not a real issue, but can make code clearer,
>   so can help the readers to analyse another issues.
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  kernel/audit_watch.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
> index 22831c4..abd8fdb 100644
> --- a/kernel/audit_watch.c
> +++ b/kernel/audit_watch.c
> @@ -456,6 +456,7 @@ void audit_remove_watch_rule(struct audit_krule *krule)
>  
>  	if (list_empty(&watch->rules)) {
>  		audit_remove_watch(watch);
> +		krule->watch = NULL;
>  
>  		if (list_empty(&parent->watches)) {
>  			audit_get_parent(parent);
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/