Date: Fri, 12 Apr 2013 11:52:01 +0000 (GMT)
From: =?euc-kr?B?x9S47cHW?= <myungjoo.ham@samsung.com>
Subject: Re: Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing
 mutex_unlock if opp_find_freq_floor fails
To: "Rafael J. Wysocki" <rjw@sisk.pl>, Axel Lin <axel.lin@ingics.com>,
        =?euc-kr?Q?=B9=DA=B0=E6=B9=CE?= <kyungmin.park@samsung.com>,
        =?euc-kr?Q?=B1=E8=B1=B9=C1=F8?= <kgene.kim@samsung.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Reply-to: myungjoo.ham@samsung.com
MIME-version: 1.0
Msgkey: 20130412115002607@myungjoo.ham
Content-type: text/plain; charset=euc-kr
MIME-version: 1.0
Message-id: <15500134.204421365767518757.JavaMail.weblogic@epv6ml01>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1526
Lines: 52

> On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
> > We need to call mutex_unlock() in the error path.
> > 
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> All three patches applied to linux-pm.git/linux-next.
> 
> Exynos maintainers, if you have any objections, please holler.
> 
> Thanks,
> Rafael

This patch was included in the last pull-request patchset
though the path was updated. (its precedessor patch moved
exynos drivers to /drivers/devfreq/exynos/* after adding
Exynos common driver files)


Cheers,
MyungJoo.

> 
> > ---
> >  drivers/devfreq/exynos4_bus.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> > index 1deee09..54b9615 100644
> > --- a/drivers/devfreq/exynos4_bus.c
> > +++ b/drivers/devfreq/exynos4_bus.c
> > @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
> >  			rcu_read_unlock();
> >  			dev_err(data->dev, "%s: unable to find a min freq\n",
> >  				__func__);
> > -			return PTR_ERR(opp);
> > +			err = PTR_ERR(opp);
> > +			goto unlock;
> >  		}
> >  		new_oppinfo.rate = opp_get_freq(opp);
> >  		new_oppinfo.volt = opp_get_voltage(opp);
> > 
> -- 
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
> 
> 
> 
>        
>   
>          
> 
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?