Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755579Ab3DLL5E (ORCPT ); Fri, 12 Apr 2013 07:57:04 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:56994 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753938Ab3DLL5C convert rfc822-to-8bit (ORCPT ); Fri, 12 Apr 2013 07:57:02 -0400 From: "Rafael J. Wysocki" To: myungjoo.ham@samsung.com Cc: Axel Lin , =?utf-8?B?67CV6rK966+8?= , =?utf-8?B?6rmA6rWt7KeE?= , "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Date: Fri, 12 Apr 2013 14:04:50 +0200 Message-ID: <5977939.Q0WPVmYRk9@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.9.0-rc6+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <15500134.204421365767518757.JavaMail.weblogic@epv6ml01> References: <15500134.204421365767518757.JavaMail.weblogic@epv6ml01> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2013 Lines: 68 On Friday, April 12, 2013 11:52:01 AM 함명주 wrote: > > On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote: > > > We need to call mutex_unlock() in the error path. > > > > > > Signed-off-by: Axel Lin > > > > All three patches applied to linux-pm.git/linux-next. > > > > Exynos maintainers, if you have any objections, please holler. > > > > Thanks, > > Rafael > > This patch was included in the last pull-request patchset > though the path was updated. (its precedessor patch moved > exynos drivers to /drivers/devfreq/exynos/* after adding > Exynos common driver files) OK, so do you want me to drop it? What about the remaining two? Do you have any more devfreq patches for me to take into v3.10? If so, please send a pull request ASAP. Thanks, Rafael > > > > > --- > > > drivers/devfreq/exynos4_bus.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c > > > index 1deee09..54b9615 100644 > > > --- a/drivers/devfreq/exynos4_bus.c > > > +++ b/drivers/devfreq/exynos4_bus.c > > > @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this, > > > rcu_read_unlock(); > > > dev_err(data->dev, "%s: unable to find a min freq\n", > > > __func__); > > > - return PTR_ERR(opp); > > > + err = PTR_ERR(opp); > > > + goto unlock; > > > } > > > new_oppinfo.rate = opp_get_freq(opp); > > > new_oppinfo.volt = opp_get_voltage(opp); > > > > > -- > > I speak only for myself. > > Rafael J. Wysocki, Intel Open Source Technology Center. > > > > > > > > > > > > > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/