Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755700Ab3DLNnz (ORCPT ); Fri, 12 Apr 2013 09:43:55 -0400 Received: from mail-ia0-f173.google.com ([209.85.210.173]:38331 "EHLO mail-ia0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139Ab3DLNny (ORCPT ); Fri, 12 Apr 2013 09:43:54 -0400 MIME-Version: 1.0 In-Reply-To: <201304121248.54005.arnd@arndb.de> References: <1365669779-14953-1-git-send-email-linus.walleij@stericsson.com> <201304121008.51300.arnd@arndb.de> <201304121248.54005.arnd@arndb.de> Date: Fri, 12 Apr 2013 15:43:52 +0200 Message-ID: Subject: Re: [PATCH] MFD: ab8500: pass AB8500 IRQ to debugfs code by resource From: Linus Walleij To: Arnd Bergmann Cc: Linus Walleij , Samuel Ortiz , "linux-kernel@vger.kernel.org" , Anmar Oueja , Lee Jones , Rickard ANDERSSON Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 39 On Fri, Apr 12, 2013 at 12:48 PM, Arnd Bergmann wrote: > On Friday 12 April 2013, Linus Walleij wrote: >> On Fri, Apr 12, 2013 at 10:08 AM, Arnd Bergmann wrote: >> > On Friday 12 April 2013, Linus Walleij wrote: >> >> >> Actually, well, this one IRQ (the one I start to pass) is already >> >> domain-mapped to the global IRQ numberspace, so that one will >> >> be correct. >> > >> > I don't know if we're talking about the same thing here. >> > >> > My point was that passing a domain-mapped IRQ number into mfd_add_devices >> > with another domain will result in the attempt to map that number into >> > another domain, which does not work. >> >> Ah, yes you're right ... now I need to find some other way >> to pass this resource ... hm. > > What is it actually needed for? In the code I'm looking at in linux-next > it only gets passed to a function that ignores it. Well that is a __attribute((weak)) function. It is overridden by suspend/resume code in the machine to ask the suspend code whether the AB8500 woke the system up. Arguably not such a nice design :-/ However that suspend code is being posted to the linux-pm mailinglist as we speak, so I don't want to make their life miserable by just deleting some hook they're actually using for testing. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/