Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753785Ab3DLPAP (ORCPT ); Fri, 12 Apr 2013 11:00:15 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:10103 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753496Ab3DLPAK convert rfc822-to-8bit (ORCPT ); Fri, 12 Apr 2013 11:00:10 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 12 Apr 2013 08:00:04 -0700 From: Jay Agarwal To: "'Stephen Warren'" CC: "linux@arm.linux.org.uk" , "thierry.reding@avionic-design.de" , Laxman Dewangan , "bhelgaas@google.com" , "olof@lixom.net" , Hiroshi Doyu , Prashant Gaikwad , "mturquette@linaro.org" , Peter De Schrijver , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Juha Tukkinen , Krishna Thota Date: Fri, 12 Apr 2013 20:28:30 +0530 Subject: RE: [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support Thread-Topic: [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support Thread-Index: Ac40hJQ0WEaybtu2QIqjIvY4b5fyJQDCSkkQ Message-ID: References: <1365435688-4179-1-git-send-email-jagarwal@nvidia.com> <51630852.1000107@wwwdotorg.org> In-Reply-To: <51630852.1000107@wwwdotorg.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1130 Lines: 27 > > err = regulator_disable(pcie->pex_clk_supply); > > if (err < 0) > > - dev_err(pcie->dev, "failed to disable pex-clk regulator: > %d\n", > > + dev_warn(pcie->dev, "failed to disable pex-clk regulator: > %d\n", > > err); > > > > err = regulator_disable(pcie->vdd_supply); > > if (err < 0) > > - dev_err(pcie->dev, "failed to disable VDD regulator: %d\n", > > + dev_warn(pcie->dev, "failed to disable VDD regulator: > %d\n", > > err); > > Please explain why that change is correct. If the regulators only exist on > Tegra20, please represent that fact in the SoC data. Regulators must always > exist, so enable/disable should never fail due to missing regulators. Actual > run-time failures seem like something that really is an error. > [>] These regulators are needed for both tegra20 & tegra30. Since we are not returning error here, so changed to dev_warn. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/