Message-ID: <1365789706.9609.92.camel@gandalf.local.home>
Subject: Re: [PATCH 0/1] uprobes/tracing: Don't pass addr=ip to
 perf_trace_buf_submit()
From: Steven Rostedt <rostedt@goodmis.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Anton Arapov <anton@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        "yrl.pp-manager.tt@hitachi.com" <yrl.pp-manager.tt@hitachi.com>
Date: Fri, 12 Apr 2013 14:01:46 -0400
In-Reply-To: <20130411115921.GA27492@redhat.com>
References: <20130329181520.GA20670@redhat.com>
	 <20130329181545.GA20697@redhat.com>
	 <20130404142522.GC8986@linux.vnet.ibm.com> <515E4938.6090809@hitachi.com>
	 <20130405150110.GA31300@redhat.com> <51628DF8.6030102@hitachi.com>
	 <20130410145818.GA30670@redhat.com> <516692BF.6070904@hitachi.com>
	 <20130411115921.GA27492@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2673
Lines: 112

On Thu, 2013-04-11 at 13:59 +0200, Oleg Nesterov wrote:
> On 04/11, Masami Hiramatsu wrote:
> >
> > (2013/04/10 23:58), Oleg Nesterov wrote:
> >
> > > And... Cough, another question ;) To simplify, lets discuss kprobe_perf_func()
> > > only. Suppose that a task hits the kprobe but this task/cpu doesn't have
> > > a counter. Can't we avoid perf_trace_buf_prepare/submit in this case?
> > > IOW, what do you think about the change below?
> >
> > Hmm, I'm not so sure how frequently this happens.
> 
> Suppose that you do, say, "perf record -e probe:some_func workload". Only
> "workload" will have the active counter, any other task which hits the
> probed some_func() will do perf_trace_buf_prepare/perf_trace_buf_submit
> just to realize that nobody wants perf_swevent_event().

Wow, you're right. Seems that perf goes through a lot of work for every
time a tracepoint is hit for *all tasks*.

> 
> Simple test-case:
> 
> 	#include <unistd.h>
> 
> 	int main(void)
> 	{
> 		int n;
> 
> 		for (n = 0; n < 1000 * 1000; ++n)
> 			getppid();
> 
> 		return 0;
> 	}
> 
> Without kprobe:
> 
> 	# time ./ppid
> 
> 	real    0m0.663s
> 	user    0m0.163s
> 	sys     0m0.500s
> 
> Activate the probe:
> 
> 	# perf probe sys_getppid
> 
> 	# perf record -e probe:sys_getppid sleep 1000 &
> 	[1] 546
> 
> Test it again 3 times:
> 
> 	# time ./ppid
> 
> Before the patch:
> 
> 	real    0m9.727s
> 	user    0m0.177s
> 	sys     0m9.547s
> 
> 	real    0m9.752s
> 	user    0m0.180s
> 	sys     0m9.573s
> 
> 	real    0m9.761s
> 	user    0m0.187s
> 	sys     0m9.573s
> 
> After the patch:
> 
> 	real    0m9.605s
> 	user	0m0.163s
> 	sys	0m9.437s
> 
> 	real	0m9.592s
> 	user	0m0.167s
> 	sys	0m9.423s
> 
> 	real	0m9.613s
> 	user	0m0.183s
> 	sys	0m9.427s
> 
> So the difference looks measurable but small, and I did the testing
> under qemu so I do not really know if we can trust the numbers.
> 
> > And, is this right way to
> > handle that case?
> 
> If only I was sure ;) I am asking.
> 
> And, to clarify, it is not that I think this change can really
> improve the perfomance. Just I am trying to understand what I have
> missed.
> 
> > If so, we can do same thing also on trace_events.
> > (perf_trace_##call in include/trace/ftrace.h)
> 
> Yes, yes, this is not kprobe-specific. It seems that more users of
> perf_trace_buf_submit() could be changed the same way.

Yeah, looks like include/trace/ftrace.h needs an update.

Frederic?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/