Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753025Ab3DLWFH (ORCPT ); Fri, 12 Apr 2013 18:05:07 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:54598 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463Ab3DLWFE (ORCPT ); Fri, 12 Apr 2013 18:05:04 -0400 MIME-Version: 1.0 In-Reply-To: <20130412130936.3f428cc9@hyperion> References: <1365441321-21952-1-git-send-email-kevin.strasser@linux.intel.com> <1365441321-21952-3-git-send-email-kevin.strasser@linux.intel.com> <20130412130936.3f428cc9@hyperion> Date: Sat, 13 Apr 2013 00:05:03 +0200 Message-ID: Subject: Re: [PATCH 3/4] gpio: Kontron PLD gpio driver From: Linus Walleij To: Michael Brunner Cc: Kevin Strasser , "linux-kernel@vger.kernel.org" , Michael Brunner , Samuel Ortiz , Wolfram Sang , Ben Dooks , "linux-i2c@vger.kernel.org" , Grant Likely , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Darren Hart , Greg Kroah-Hartman , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 23 On Fri, Apr 12, 2013 at 1:09 PM, Michael Brunner wrote: >> (...) >> > +struct kempld_gpio_data { >> > + struct gpio_chip chip; >> > + int irq; >> > + struct kempld_device_data *pld; >> > + uint16_t mask; >> >> Just u16? > > The specification allows 16 GPIOs for this device, therefore this seems > to be the right size. Would it be better to use another type instead? Ah, I was just asking you to use "u16" instead of "uint16_t". Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/