Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757462Ab3DLWqo (ORCPT ); Fri, 12 Apr 2013 18:46:44 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47599 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756630Ab3DLWqm (ORCPT ); Fri, 12 Apr 2013 18:46:42 -0400 From: Yinghai Lu To: Bjorn Helgaas , Ram Pai Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yinghai Lu Subject: [PATCH v4 17/29] PCI: Use for_each_pci_resource() in pci_dev_driver() Date: Fri, 12 Apr 2013 15:44:31 -0700 Message-Id: <1365806683-26717-18-git-send-email-yinghai@kernel.org> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1365806683-26717-1-git-send-email-yinghai@kernel.org> References: <1365806683-26717-1-git-send-email-yinghai@kernel.org> X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 33 Replace those open code, and make code more readable. Signed-off-by: Yinghai Lu --- drivers/pci/pci-driver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 1fa1e48..009f6c2 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1170,9 +1170,11 @@ pci_dev_driver(const struct pci_dev *dev) if (dev->driver) return dev->driver; else { + struct resource *res; int i; - for(i=0; i<=PCI_ROM_RESOURCE; i++) - if (dev->resource[i].flags & IORESOURCE_BUSY) + + for_each_pci_resource((struct pci_dev *)dev, res, i, PCI_STD_ROM_RES) + if (res->flags & IORESOURCE_BUSY) return &pci_compat_driver; } return NULL; -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/