From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "myungjoo.ham" <myungjoo.ham@samsung.com>,
        "'Axel Lin'" <axel.lin@ingics.com>
Cc: "'Kyungmin Park'" <kyungmin.park@samsung.com>,
        "'Kukjin Kim'" <kgene.kim@samsung.com>,
        "'Rafael J. Wysocki'" <rafael.j.wysocki@intel.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails
Date: Sat, 13 Apr 2013 01:20:23 +0200
Message-ID: <2583577.Kz0O4QXtvD@vostro.rjw.lan>
User-Agent: KMail/4.9.5 (Linux/3.9.0-rc6+; KDE/4.9.5; x86_64; ; )
In-Reply-To: <002101ce3776$cbc83f90$6358beb0$@samsung.com>
References: <1365746058.4025.1.camel@phoenix> <1413655.hhUbBAKNUi@vostro.rjw.lan> <002101ce3776$cbc83f90$6358beb0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2371
Lines: 69

On Friday, April 12, 2013 09:11:00 PM myungjoo.ham wrote:
> > On Friday, April 12, 2013 11:52:01 AM 함명주 wrote:
> > > > On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
> > > > > We need to call mutex_unlock() in the error path.
> > > > > 
> > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > > > 
> > > > All three patches applied to linux-pm.git/linux-next.
> > > > 
> > > > Exynos maintainers, if you have any objections, please holler.
> > > > 
> > > > Thanks,
> > > > Rafael
> > > 
> > > This patch was included in the last pull-request patchset
> > > though the path was updated. (its precedessor patch moved
> > > exynos drivers to /drivers/devfreq/exynos/* after adding
> > > Exynos common driver files)
> > 
> > OK, so do you want me to drop it?
> > 
> > What about the remaining two?
> 
> Yes, please drop 1/3. It's duplicated.
> 
> The patches 2~3/3 can wait. They are actually not bugfixes.

OK, I've dropped all three.

Axel, please push [2-3/3] thorugh the Exynos tree.

Thanks,
Rafael


> > > > > ---
> > > > >  drivers/devfreq/exynos4_bus.c |    3 ++-
> > > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> > > > > index 1deee09..54b9615 100644
> > > > > --- a/drivers/devfreq/exynos4_bus.c
> > > > > +++ b/drivers/devfreq/exynos4_bus.c
> > > > > @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
> > > > >  			rcu_read_unlock();
> > > > >  			dev_err(data->dev, "%s: unable to find a min freq\n",
> > > > >  				__func__);
> > > > > -			return PTR_ERR(opp);
> > > > > +			err = PTR_ERR(opp);
> > > > > +			goto unlock;
> > > > >  		}
> > > > >  		new_oppinfo.rate = opp_get_freq(opp);
> > > > >  		new_oppinfo.volt = opp_get_voltage(opp);
> > > > > 
> > 
> >
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/