Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753584Ab3DLXSI (ORCPT ); Fri, 12 Apr 2013 19:18:08 -0400 Received: from tex.lwn.net ([70.33.254.29]:49852 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577Ab3DLXSH (ORCPT ); Fri, 12 Apr 2013 19:18:07 -0400 Date: Fri, 12 Apr 2013 17:18:05 -0600 From: Jake Edge To: Jake Edge Cc: hpa@linux.intel.com, rjw@sisk.pl, linux-kernel@vger.kernel.org Subject: Re: sleep/fan problem bisected to 73201dbec64aebf6b0dca855b523f437972dc7bb Message-ID: <20130412171805.1077ae7f@chukar.edge2.net> In-Reply-To: <20130412120831.1402b440@chukar.edge2.net> References: <20130412120831.1402b440@chukar.edge2.net> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.16; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1877 Lines: 42 On Fri, 12 Apr 2013 12:08:31 -0600 Jake Edge wrote: > I have been having a problem on my laptop (HP Compaq 2510p) over the > last two months with >= 3.7 kernels. After the first resume, it turns > on the fan and leaves it running at top speed no matter what the > system is doing. I finally bisected it over the last two days and > that points the finger at your patch > 73201dbec64aebf6b0dca855b523f437972dc7bb: > > x86, suspend: On wakeup always initialize cr4 and EFER > > We already have a flag word to indicate the existence of > MISC_ENABLES, so use the same flag word to indicate existence of cr4 > and EFER, and always restore them if they exist. That way if > something passes a nonzero value when the value *should* be zero, we > will still initialize it. > > I should note that the bisection (between 3.6, which works, and 3.7, > which doesn't) did not exhibit the same symptoms as I see with any 3.7 > or 3.8 kernel (either from Fedora or built myself), but would instead > refuse to come out of sleep (but still have the fan running at top > speed) ... so maybe I've really bisected the "fails to come out of > sleep" problem, rather than the "fan runs at top speed after resume" > problem, dunno ... As you've undoubtedly surmised, I was in fact tracking down the resume failure which was caused by the above and fixed by another of your patches: 1396adc3c2bdc556d4cdd1cf107aa0b6d59fbb1e ... neither of which were related to the fan issue as far as I can tell ... now I am off bisecting while applying those ... sorry for the noise ... jake -- Jake Edge - LWN - jake@lwn.net - http://lwn.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/