Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790Ab3DMOKk (ORCPT ); Sat, 13 Apr 2013 10:10:40 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:64918 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370Ab3DMOKi (ORCPT ); Sat, 13 Apr 2013 10:10:38 -0400 MIME-Version: 1.0 X-Originating-IP: [114.39.107.246] In-Reply-To: <1365424274.21989.2.camel@phoenix> References: <1365424274.21989.2.camel@phoenix> Date: Sat, 13 Apr 2013 22:10:38 +0800 Message-ID: Subject: Re: [PATCH] regulator: ab8500: Fix get_mode for shared mode regulators From: Axel Lin To: Mark Brown Cc: Bengt Jonsson , Lee Jones , Yvan FILLION , Liam Girdwood , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1823 Lines: 55 Ping. Hi Lee, Can you review this patch. I think this one is a bug fix. Regards, Axel 2013/4/8 Axel Lin : > The special handling code for getting shared mode status is wrong > because it needs to check info->shared_mode->lp_mode_req for > both regulators that shared the same mode register. > > In set_mode(), current code ensures we won't set mode to REGULATOR_MODE_IDLE > if only one of the regulator requests to set idle. > > In get_mode(), we can just remove the special handling code for shared mode. > Read the register value always returns correct status no matter the regulator > has shared mode register or not. > > Signed-off-by: Axel Lin > --- > drivers/regulator/ab8500.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c > index 9ebd131..acdffc5 100644 > --- a/drivers/regulator/ab8500.c > +++ b/drivers/regulator/ab8500.c > @@ -456,14 +456,6 @@ static unsigned int ab8500_regulator_get_mode(struct regulator_dev *rdev) > return -EINVAL; > } > > - /* Need special handling for shared mode */ > - if (info->shared_mode) { > - if (info->shared_mode->lp_mode_req) > - return REGULATOR_MODE_IDLE; > - else > - return REGULATOR_MODE_NORMAL; > - } > - > if (info->mode_mask) { > /* Dedicated register for handling mode */ > ret = abx500_get_register_interruptible(info->dev, > -- > 1.7.10.4 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/