Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518Ab3DOE4h (ORCPT ); Mon, 15 Apr 2013 00:56:37 -0400 Received: from ozlabs.org ([203.10.76.45]:49980 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396Ab3DOE4e (ORCPT ); Mon, 15 Apr 2013 00:56:34 -0400 Date: Mon, 15 Apr 2013 14:56:14 +1000 From: Paul Mackerras To: Jiang Liu Cc: Andrew Morton , Yinghai Lu , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , David Howells , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 00/19] kill free_all_bootmem() and clean up VALID_PAGE() Message-ID: <20130415045614.GB7494@iris.ozlabs.ibm.com> References: <1365867399-21323-1-git-send-email-jiang.liu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365867399-21323-1-git-send-email-jiang.liu@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 37 On Sat, Apr 13, 2013 at 11:36:20PM +0800, Jiang Liu wrote: > Commit 600cc5b7f6 "mm: Kill NO_BOOTMEM version free_all_bootmem_node()" > has kill free_all_bootmem_node() for NO_BOOTMEM. > > Currently the usage pattern for free_all_bootmem_node() is like: > for_each_online_pgdat(pgdat) > free_all_bootmem_node(pgdat); > > It's equivalent to free_all_bootmem(), so this patchset goes one > step further to kill free_all_bootmem_node() for BOOTMEM too. > > This patchset also tries to clean up code and comments related to > VALID_PAGE() because it has been removed from kernel long time ago. > > Patch 1-11: > Kill free_all_bootmem_node() > Patch 12-16: > Clean up code and comments related to VALID_PAGE() > Patch 17: > Fix a minor build warning for m68k > Patch 18: > merge Alpha's mem_init() for UMA and NUMA. > Patch 19: > call register_page_bootmem_info_node() from mm core How does this not break bisection? Will a kernel still boot with patches 1-11 applied but not patch 19? As far as I can see such a kernel would have no memory available to it after mem_init() time and would therefore crash early in boot. Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/