Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933585Ab3DOFx3 (ORCPT ); Mon, 15 Apr 2013 01:53:29 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:57202 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752075Ab3DOFx2 (ORCPT ); Mon, 15 Apr 2013 01:53:28 -0400 Message-ID: <1366005207.1878.43.camel@joe-AO722> Subject: Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ? From: Joe Perches To: Heiko Carstens Cc: Martin Schwidefsky , linux-s390@vger.kernel.org, LKML Date: Sun, 14 Apr 2013 22:53:27 -0700 In-Reply-To: <20130415054814.GA4207@osiris> References: <1365919574.1878.13.camel@joe-AO722> <20130415054814.GA4207@osiris> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 16 On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > > Commit ea81531d ("s390/uaccess: fix page table walk") > > added this code. It looks like it should have break; > > for each case. > no, the fallthrough is on purpose for each case statement. Hi again. It might be useful to add /* fallthrough */ or some other comment showing it's intentional. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/