Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934949Ab3DOF6a (ORCPT ); Mon, 15 Apr 2013 01:58:30 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:60120 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934518Ab3DOF62 (ORCPT ); Mon, 15 Apr 2013 01:58:28 -0400 Date: Mon, 15 Apr 2013 07:58:23 +0200 From: Heiko Carstens To: Joe Perches Cc: Martin Schwidefsky , linux-s390@vger.kernel.org, LKML Subject: Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ? Message-ID: <20130415055822.GC4207@osiris> References: <1365919574.1878.13.camel@joe-AO722> <20130415054814.GA4207@osiris> <1366005207.1878.43.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366005207.1878.43.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13041505-2966-0000-0000-00000748F644 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 21 On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote: > On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote: > > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote: > > > Commit ea81531d ("s390/uaccess: fix page table walk") > > > added this code. It looks like it should have break; > > > for each case. > > no, the fallthrough is on purpose for each case statement. > > Hi again. It might be useful to add /* fallthrough */ > or some other comment showing it's intentional. I might add some comment above the function, since for everybody *knowing* the architecture it's obvious ;) that these must be fallthroughs. How did you stuble across this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/