Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166Ab3DOL7N (ORCPT ); Mon, 15 Apr 2013 07:59:13 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:48715 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199Ab3DOL7M (ORCPT ); Mon, 15 Apr 2013 07:59:12 -0400 Date: Mon, 15 Apr 2013 12:59:06 +0100 From: Lee Jones To: Rabin Vincent Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com Subject: Re: [PATCH 3/8] dmaengine: ste_dma40: Actually write the runtime configuration to registers Message-ID: <20130415115906.GF6512@gmail.com> References: <1365532783-27425-1-git-send-email-lee.jones@linaro.org> <1365532783-27425-3-git-send-email-lee.jones@linaro.org> <20130415110601.GE6512@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2213 Lines: 50 On Mon, 15 Apr 2013, Rabin Vincent wrote: > 2013/4/15 Lee Jones : > > On Fri, 12 Apr 2013, Rabin Vincent wrote: > >> 2013/4/9 Lee Jones : > >> > Someone has spent a fair amount of effort writing a runtime configuration > >> > changing algorithm for DMA clients. However, the config appears to never > >> > actually make it to hardware. In order for the configuration to take hold > >> > we need to issue a d40_config_write(), as this is the routine which writes > >> > it into the hardware's registers. > >> > >> No, it's not. This function is only for initial configuration which > >> should only be written when the channel is allocated. In fact, by > >> calling it here in runtime_config, you are introducing a serious bug: > >> other logical channels on the same physical channel will stop because of > >> the SSLNK/SDLNK of the physical channel being zeroed. > >> > >> The runtime config already makes it the hardware in the existing code, > >> via d40_*_cfg(). > > > > Sorry Rabin, but the only place I can see the config being written is > > in d40_config_write(). > > > > Can you paste the line of code in d40_*_cfg() which actually writes > > the config to hardware please? I don't see it. > > It's not that simple. There are some pointers passed to d40_*_cfg() and > that function writes the configuration to the variables those pointers > point to (d40c->log_def.lcsp1, d40c->src_def_cfg, etc.). Please read > the code to see how those variables end up being used later when the > LLIs are prepared for the HW. I have read the code, which is why I know that the config only gets written in d40_config_write(). :) So the configuration which gets set in the runtime_config routine doesn't ever make it to hardware - hence this patch. Unless I'm missing something? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/