Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755800Ab3DOQL0 (ORCPT ); Mon, 15 Apr 2013 12:11:26 -0400 Received: from mail.skyhub.de ([78.46.96.112]:37279 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753508Ab3DOQLY (ORCPT ); Mon, 15 Apr 2013 12:11:24 -0400 Date: Mon, 15 Apr 2013 18:11:21 +0200 From: Borislav Petkov To: Bjorn Helgaas Cc: Aravind Gopalakrishnan , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Doug Thompson , Jesse Barnes , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , linux-edac@vger.kernel.org Subject: Re: [PATCH] edac: Handle EDAC ECC errors for Family 16h Message-ID: <20130415161121.GA18440@pd.tnic> References: <1366039059-15772-1-git-send-email-Aravind.Gopalakrishnan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1966 Lines: 58 On Mon, Apr 15, 2013 at 09:56:08AM -0600, Bjorn Helgaas wrote: > On Mon, Apr 15, 2013 at 9:17 AM, Aravind Gopalakrishnan > > @@ -172,7 +176,12 @@ > > */ > > #define PCI_DEVICE_ID_AMD_15H_NB_F1 0x1601 > > #define PCI_DEVICE_ID_AMD_15H_NB_F2 0x1602 > > - > > +#define PCI_DEVICE_ID_AMD_16H_NB_F0 0x1530 > > +#define PCI_DEVICE_ID_AMD_16H_NB_F1 0x1531 > > +#define PCI_DEVICE_ID_AMD_16H_NB_F2 0x1532 > > +#define PCI_DEVICE_ID_AMD_16H_NB_F3 0x1533 > > +#define PCI_DEVICE_ID_AMD_16H_NB_F4 0x1534 > > +#define PCI_DEVICE_ID_AMD_16H_NB_F5 0x1535 > > > > /* > > * Function 1 - Address Map > > @@ -300,6 +309,7 @@ enum amd_families { > > K8_CPUS = 0, > > F10_CPUS, > > F15_CPUS, > > + F16_CPUS, > > NUM_FAMILIES, > > }; > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index 1679ff6..59f732f 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -519,6 +519,8 @@ > > #define PCI_DEVICE_ID_AMD_11H_NB_LINK 0x1304 > > #define PCI_DEVICE_ID_AMD_15H_NB_F3 0x1603 > > #define PCI_DEVICE_ID_AMD_15H_NB_F4 0x1604 > > +#define PCI_DEVICE_ID_AMD_16H_NB_F3 0x1533 > > +#define PCI_DEVICE_ID_AMD_16H_NB_F4 0x1534 > > What is the point of adding identical #defines both here and in > amd64_edac.h? Also, read the note at the top of > include/linux/pci_ids.h. Yeah, they should be in pci_ids.h since they're used in amd_nb.c and amd64_edac.c. But, what shouldn't be is adding unused defines (*_F0 and *_F5). Aravind, please drop them. I'll review the rest of the patch when I get around to it this week. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/