Message-ID: <1366046457.6170.1.camel@dabdike>
Subject: Re: [PATCH] scsi: pcmcia: nsp_cs: remove module init/exit function
 prototypes
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        fengguang.wu@intel.com, yokota@netlab.is.tsukuba.ac.jp,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Mon, 15 Apr 2013 10:20:57 -0700
In-Reply-To: <201304150942.37837.hsweeten@visionengravers.com>
References: <201304150942.37837.hsweeten@visionengravers.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 928
Lines: 28

On Mon, 2013-04-15 at 09:42 -0700, H Hartley Sweeten wrote:
> This driver now uses the module_pcmcia_driver() macro to supply the
> init/exit code. The nsp_cs_{init,exit} prototypes should be removed.

This reasoning is bogus.

Why the driver actually has all these static prototypes in its header
file is entirely unclear to me, but singling these two out for the
reason you state above is wrong (both the reason and picking only two of
them).

Hiroshi, you're the maintainer, what do you want to do ... since the
driver is ancient, I'm happy to leave it untouched, or if you want to
tidy it up, I see no reason to have any static prototypes in the header
file.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/