Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755004Ab3DPADV (ORCPT ); Mon, 15 Apr 2013 20:03:21 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:51331 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753595Ab3DPADU (ORCPT ); Mon, 15 Apr 2013 20:03:20 -0400 Date: Tue, 16 Apr 2013 02:03:16 +0200 From: Frederic Weisbecker To: Oleg Nesterov Cc: Andrew Morton , Alan Stern , Ingo Molnar , Jan Kratochvil , Maneesh Soni , Prasad , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ptrace/x86: simplify the "disable" logic in ptrace_write_dr7() Message-ID: <20130416000314.GF17561@somewhere.redhat.com> References: <20130414191205.GA28791@redhat.com> <20130414191228.GA28809@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130414191228.GA28809@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 636 Lines: 14 On Sun, Apr 14, 2013 at 09:12:28PM +0200, Oleg Nesterov wrote: > ptrace_write_dr7() looks unnecessarily overcomplicated. We can > factor out ptrace_modify_breakpoint() and do not do "continue" > twice, just we need to pass the proper "disabled" argument to > ptrace_modify_breakpoint(). > > Signed-off-by: Oleg Nesterov Acked-by: Frederic Weisbecker -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/