Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935301Ab3DPBlh (ORCPT ); Mon, 15 Apr 2013 21:41:37 -0400 Received: from li9-11.members.linode.com ([67.18.176.11]:34474 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934863Ab3DPBlg (ORCPT ); Mon, 15 Apr 2013 21:41:36 -0400 Date: Mon, 15 Apr 2013 21:41:09 -0400 From: "Theodore Ts'o" To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-aio@kvack.org, akpm@linux-foundation.org, Zach Brown , Felipe Balbi , Greg Kroah-Hartman , Mark Fasheh , Joel Becker , Rusty Russell , Jens Axboe , Asai Thambi S P , Selvan Mani , Sam Bradshaw , Jeff Moyer , Al Viro , Benjamin LaHaise Subject: Re: [PATCH 23/33] generic dynamic per cpu refcounting Message-ID: <20130416014109.GA11005@thunk.org> Mail-Followup-To: Theodore Ts'o , Kent Overstreet , linux-kernel@vger.kernel.org, linux-aio@kvack.org, akpm@linux-foundation.org, Zach Brown , Felipe Balbi , Greg Kroah-Hartman , Mark Fasheh , Joel Becker , Rusty Russell , Jens Axboe , Asai Thambi S P , Selvan Mani , Sam Bradshaw , Jeff Moyer , Al Viro , Benjamin LaHaise References: <1363883754-27966-1-git-send-email-koverstreet@google.com> <1363883754-27966-24-git-send-email-koverstreet@google.com> <20130402162738.GG31577@thunk.org> <20130412193600.GA31761@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130412193600.GA31761@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 695 Lines: 16 On Fri, Apr 12, 2013 at 12:36:00PM -0700, Kent Overstreet wrote: > It would be nice if we had unsigned atomic types... but given that we > don't and I'm pretty sure overflow in atomic types happens all over the > place that part honestly seems fine to me... > > That said, I suppose a comment indicating that it is intentionally > overflowing is probably merited. Ted, Andrew, is this acceptable to you? Seems reasonable to me, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/