Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935971Ab3DPOrT (ORCPT ); Tue, 16 Apr 2013 10:47:19 -0400 Received: from mga02.intel.com ([134.134.136.20]:62796 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935614Ab3DPOrR (ORCPT ); Tue, 16 Apr 2013 10:47:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,486,1363158000"; d="scan'208";a="319066113" From: "Kirill A. Shutemov" To: Dave Hansen Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <51631CC0.5010908@sr71.net> References: <1365163198-29726-1-git-send-email-kirill.shutemov@linux.intel.com> <1365163198-29726-10-git-send-email-kirill.shutemov@linux.intel.com> <51631CC0.5010908@sr71.net> Subject: Re: [PATCHv3, RFC 09/34] thp: represent file thp pages in meminfo and friends Content-Transfer-Encoding: 7bit Message-Id: <20130416144917.8FEAEE0085@blue.fi.intel.com> Date: Tue, 16 Apr 2013 17:49:17 +0300 (EEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 22 Dave Hansen wrote: > On 04/05/2013 04:59 AM, Kirill A. Shutemov wrote: > > The patch adds new zone stat to count file transparent huge pages and > > adjust related places. > > > > For now we don't count mapped or dirty file thp pages separately. > > I can understand tracking NR_FILE_TRANSPARENT_HUGEPAGES itself. But, > why not also account for them in NR_FILE_PAGES? That way, you don't > have to special-case each of the cases below: Good point. To be consistent I'll also convert NR_ANON_TRANSPARENT_HUGEPAGES to be accounted in NR_ANON_PAGES. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/