Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755079Ab3DPOzw (ORCPT ); Tue, 16 Apr 2013 10:55:52 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:50358 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754056Ab3DPOzu (ORCPT ); Tue, 16 Apr 2013 10:55:50 -0400 MIME-Version: 1.0 In-Reply-To: <001601ce3a85$16087f00$42197d00$%jun@samsung.com> References: <1365698338-27503-1-git-send-email-dianders@chromium.org> <001701ce39d2$c0dbf8c0$4293ea40$%jun@samsung.com> <001601ce3a85$16087f00$42197d00$%jun@samsung.com> Date: Tue, 16 Apr 2013 07:55:48 -0700 X-Google-Sender-Auth: yhZ3ZibLwxnDJIsbVL77Sas4Xco Message-ID: Subject: Re: [PATCH] mmc: dw_mmc: exynos: Turn SDIO interrupts on From: Doug Anderson To: Seungwon Jeon Cc: Chris Ball , Thomas Abraham , Bing Zhao , Jaehoon Chung , Sachin Kamat , Olof Johansson , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 20 Seungwon, On Tue, Apr 16, 2013 at 2:30 AM, Seungwon Jeon wrote: > If needed for specific channel, it can be got from dts as property. > if (of_find_property(np, "cap-sdio-irq", NULL)) > pdata->caps |= MMC_CAP_SDIO_IRQ; Oh! I missed that these new properties had gone in. That is a much better way to do it. Let's abandon this patch and I'll post up a device tree change that turns interrupts for the right ports on the exynos5250-snow and we can call it done. Thanks for the review and for pointing me to the new properties! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/