Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935056Ab3DPSVG (ORCPT ); Tue, 16 Apr 2013 14:21:06 -0400 Received: from mail-ve0-f179.google.com ([209.85.128.179]:56934 "EHLO mail-ve0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752550Ab3DPSVE (ORCPT ); Tue, 16 Apr 2013 14:21:04 -0400 MIME-Version: 1.0 In-Reply-To: References: <1366058481-21033-1-git-send-email-ccross@android.com> Date: Tue, 16 Apr 2013 11:21:02 -0700 X-Google-Sender-Auth: 5wbBlQAgMJXC6XRA88WcRnLs-H4 Message-ID: Subject: Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set From: Linus Torvalds To: Miklos Szeredi Cc: Colin Cross , lkml , "open list:FUSE: FILESYSTEM..." , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 19 > What I meant is IF is included by userspace (it sure is > meant to be included and *is* included by libfuse and other stuff) > THEN using instead of is fine regardless of > whether __linux__ is defined or not. That's probably true. But the patch in question adds the __KERNEL__ test, and *that* seems required. If you think that we should instead drop the __linux__ test, than yes, that part sounds fine. I thought that by "linux internal header" you meant the fuse.h file, but you seem to mean the indirectly included . That's fine. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/