Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965262Ab3DPS3w (ORCPT ); Tue, 16 Apr 2013 14:29:52 -0400 Received: from mail-vc0-f175.google.com ([209.85.220.175]:54804 "EHLO mail-vc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753948Ab3DPS3t (ORCPT ); Tue, 16 Apr 2013 14:29:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1366058481-21033-1-git-send-email-ccross@android.com> Date: Tue, 16 Apr 2013 11:29:48 -0700 X-Google-Sender-Auth: PTZzSv2ddJyZcBNwaIYGmk_ulfA Message-ID: Subject: Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set From: Colin Cross To: Linus Torvalds Cc: Miklos Szeredi , lkml , "open list:FUSE: FILESYSTEM..." , =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 33 On Tue, Apr 16, 2013 at 11:21 AM, Linus Torvalds wrote: >> What I meant is IF is included by userspace (it sure is >> meant to be included and *is* included by libfuse and other stuff) >> THEN using instead of is fine regardless of >> whether __linux__ is defined or not. > > That's probably true. But the patch in question adds the __KERNEL__ > test, and *that* seems required. > > If you think that we should instead drop the __linux__ test, than yes, > that part sounds fine. I thought that by "linux internal header" you > meant the fuse.h file, but you seem to mean the indirectly included > . That's fine. > > Linus Dropping __linux__ causes a make headers_check warning, which the kbuild test robot reported this morning: usr/include/linux/fuse.h:99: found __[us]{8,16,32,64} type without #include Using my patch without modification does not cause that warning. linux/types.h defines the types that are used to communicate between the kernel and userspace. Redefining those in each header makes no sense, and will probably cause redefined types warnings if you compile a userspace file that includes fuse.h and another uapi header that properly includes linux/types.h. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/