Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965518Ab3DPWWZ (ORCPT ); Tue, 16 Apr 2013 18:22:25 -0400 Received: from terminus.zytor.com ([198.137.202.10]:48984 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965353Ab3DPWWY (ORCPT ); Tue, 16 Apr 2013 18:22:24 -0400 Message-ID: <516DCEF3.6030803@zytor.com> Date: Tue, 16 Apr 2013 15:21:39 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Kees Cook CC: linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, Thomas Gleixner , Ingo Molnar , x86@kernel.org, Jarkko Sakkinen , Matthew Garrett , Matt Fleming , Eric Northup , Dan Rosenberg , Julien Tinnes , Will Drewry Subject: Re: [PATCH 4/6] x86: relocs: build separate 32/64-bit tools References: <1365797627-20874-1-git-send-email-keescook@chromium.org> <1365797627-20874-5-git-send-email-keescook@chromium.org> In-Reply-To: <1365797627-20874-5-git-send-email-keescook@chromium.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 31 On 04/12/2013 01:13 PM, Kees Cook wrote: > Since the ELF structures and access macros change size based on 32 vs > 64 bits, build a separate 32-bit relocs tool (for handling realmode > and 32-bit relocations), and a 64-bit relocs tool (for handling 64-bit > kernel relocations). > > Signed-off-by: Kees Cook > -- > This is ugly with the "cp". Is there some other cleaner way to trigger > two builds with different defines from the same source file? There definitely is. Have simple wrapper files which do: /* relocs_32.c */ #define ELF_BITS 32 #include "relocs.c" /* relocs_64.c */ #define ELF_BITS 64 #include "relocs.c" -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/